DataFusion PR Review

This skill describes the mechanics for doing PR reviews from the command line.

When creating a PR, skip the "Collect PR context" step and instead check the changes against each area of the PR review guide before submitting.

Collect PR context

• Check out the PR locally: gh pr checkout <PR number> (ask first if the working tree has other work in progress).
• Fetch the PR description, comments, and reviews: gh pr view <PR number> --json title,body,comments,reviews
• Fetch CI status: gh pr checks <PR number>.

Compute the diff

# find the remote that points at apache/datafusion (e.g. `apache`, `upstream`, or `origin`)
UPSTREAM=$(git remote -v | grep -m1 'apache/datafusion' | cut -f1)
git fetch $UPSTREAM main
git diff $(git merge-base HEAD $UPSTREAM/main)

Review checklist

Work through each area from the PR review guide.