本文へ移動
cccskills
無料GitHub で公開

review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

インストール方法を見る

含まれるファイル(6)

  • SKILL.md7.7 KB
  • references/architecture-smell-baseline.md6.8 KB
  • references/audit-playbook.md10.2 KB
  • references/go-review-patterns.md4.0 KB
  • references/receiving-feedback.md3.0 KB
  • references/report-template.md1.9 KB

SKILL.md(原文)

インストールする前に、エージェントに与えられる指示の中身を確認できます。

Review

Three modes. Pick one by request shape, default to systematic.

Request matchesMode
Review a file, diff, or PRSystematic (default)
"parallel review", "multi-reviewer", "3-reviewer"Parallel
"full repo review", "codebase audit", "repo health", review ALL filesFull-repo

Deep References

SignalLoadWhy
Reviewing Go codereferences/go-review-patterns.mdExports, concurrency, resources, metrics, tests
Dispatching Architecture reviewer in parallel modereferences/architecture-smell-baseline.md12 Fowler smells with language counter-examples and severity cap
Writing full-repo reportreferences/report-template.mdReport structure and field definitions
Dispatching full-repo wave agentsreferences/audit-playbook.md8-category checklists with evidence requirements
Receiving review feedbackreferences/receiving-feedback.mdFeedback-handling patterns

Severity Classification

Shared across all modes. When in doubt, classify UP.

LevelScopeExamples
BLOCKINGSecurity, correctness, reliabilityAuth bypass, race condition, resource leak, logic error, test failure
SHOULD FIXMaterial quality, patterns, testsMissing tests, unhelpful errors, pattern violations, N+1 in hot paths
SUGGESTIONOptional, stylisticNaming preferences, comments, micro-optimizations

Decision: security/correctness/reliability risk? -> BLOCKING. Violates patterns or creates maintenance burden? -> SHOULD FIX. Purely stylistic? -> SUGGESTION.

Verdict Rules

ConditionVerdict
Any BLOCKING findingREQUEST-CHANGES (or BLOCK)
SHOULD FIX findings, no BLOCKINGFIX before merge
Only SUGGESTION or cleanAPPROVE

Omit empty severity sections. Include review scope, evidence, and limitations. Validate output:

python3 scripts/validate-review-output.py --type systematic /tmp/review-output.md

Exit 0 = valid; 1 = schema errors; 2 = unparseable; 3 = missing jsonschema.


Mode 1: Systematic Review (default)

Single-reviewer, 4-phase review of a named file, diff, or PR.

Phase 1: UNDERSTAND

Read repository instructions and the complete diff. Read surrounding code to understand each changed path and its consumers. When signatures change, find all callers and interface implementations. Trace parameters to their source: query params may hold any user string; tokens may be server-issued IDs; enums have bounded values. Check validation at each caller.

Gate: Every changed path accounted for, callers traced where needed.

Phase 2: VERIFY

Run relevant tests and required repository checks. Reuse prior results only when they cover current code and environment. Check material claims in comments and PR description against code and tests. Missing tools, skipped checks, and inferred outcomes are not passes.

Gate: Claims have supporting evidence; required checks passed or the gap is recorded.

Phase 3: ASSESS

Assess risks: security (auth, validation, injection, secrets), performance (N+1, unbounded work, allocations on hot paths), architecture (conventions, compatibility, scope, unnecessary abstractions). For extracted helpers, recheck contract and callers.

Gate: Relevant risks and remaining uncertainty are explicit.

Phase 3.5: VERIFY FINDINGS

Before reporting, check each finding's input sequence, existing guards, and proposed fix. Drop unreachable or already-handled claims. Deduplicate when combining reviews; resolve severity from evidence.

Phase 4: DOCUMENT

Review Summary:
  Files Reviewed: N | Lines Changed: +X/-Y
  Test Status: PASS | FAIL | SKIPPED
  Risk Level: LOW | MEDIUM | HIGH | CRITICAL

BLOCKING:
  1. Issue and consequence — path/file.ext:42
SHOULD FIX:
  1. Issue and consequence — path/file.ext:52
SUGGESTIONS:
  1. Optional improvement — path/file.ext:62

Verdict: APPROVE | REQUEST-CHANGES | NEEDS-DISCUSSION
Rationale: Evidence, scope, and limitations.

Mode 2: Parallel Review

Three concurrent reviewers, then aggregate.

Step 1: Scope

Identify the diff or files. Record the reviewed revision.

git diff --name-only HEAD
gh pr view --json files -q '.files[].path'

Select Architecture reviewer by language: Go -> golang-general-engineer; Python -> python-general-engineer; TypeScript -> typescript-frontend-engineer; mixed -> Explore.

Step 2: Dispatch

Dispatch three reviewers together. Read-only; no code edits.

ReviewerFocus
SecurityAuth, authorization, input validation, secrets, OWASP
Business LogicRequirements, edge cases, state transitions, failure modes
ArchitectureDesign, structure, performance, maintainability, scope

Pass references/architecture-smell-baseline.md verbatim to the Architecture reviewer. Require [Reviewer] file:line format with severity and consequence.

Step 3: Aggregate and Verdict

Deduplicate findings, resolve severity disagreements from evidence. Apply shared verdict rules. Output a single combined report with severity matrix, combined findings, and recommendation.

Gate: Every reviewer returned, or missing coverage is explicitly stated without claiming approval.


Mode 3: Full-Repo Review

All source files through a 4-wave comprehensive review. Produces a prioritized backlog, not auto-fixes. Use for quarterly health checks, post-refactor audits, or new codebase onboarding.

Options: --directory [dir] (scope to one dir), --skip-precheck, --min-severity [level].

Step 1: Discover and Pre-check

Scan all source files (scripts/, hooks/, skills/, agents/, docs/). Never fall back to git diff.

python3 ~/.claude/scripts/score-component.py --all-agents --all-skills --json

Save scores as triage context. A score alone never determines severity.

Step 2: Run Comprehensive Review

Call comprehensive-review with --review-only and the full file list. Run all 4 waves (0-3). Load references/audit-playbook.md as prompt context for wave agents.

Step 3: Report

Merge deterministic scores with LLM findings. Identify systemic patterns (3+ files). Write full-repo-review-report.md using references/report-template.md.

Gate: Report exists with severity sections and deterministic scores.


Error Handling

ErrorSolution
Reviewer times out or returns nothingReport partial findings, note gap, retry on reduced scope
Validator script missingRun review without validation, note gap in verdict
score-component.py failsProceed with LLM review only, note gap in report
Too many files for single sessionSplit by directory: scripts/, hooks/, agents/, skills/

レビュー

まだレビューはありません。使ってみた感想をお寄せください。

同じリポジトリのスキル

概要と使いどころ

accounts

無料

Manage multiple Claude Code accounts: add, list, check, launch, and install shell aliases for 10+ isolated CLAUDE_CONFIG_DIR profiles.

日本語の概要は準備中です。原文の説明を表示しています。

notque/vexjoy-agent4412026年10月12日 更新

Improve architecture across modules by deepening interfaces.

日本語の概要は準備中です。原文の説明を表示しています。

notque/vexjoy-agent4412026年10月12日 更新

Assessment: read-only inspection, codebase overview, value analysis, health checks, ADR consultation, decision analysis, multi-perspective critique.

日本語の概要は準備中です。原文の説明を表示しています。

notque/vexjoy-agent4412026年10月12日 更新

Background memory consolidation — overnight review, merge, and injection payload for memory files.

日本語の概要は準備中です。原文の説明を表示しています。

notque/vexjoy-agent4412026年10月12日 更新

Jev-driven browser automation: Jev picks operations, programs execute, a text model writes field values only when Jev cannot pick one from the goal.

日本語の概要は準備中です。原文の説明を表示しています。

notque/vexjoy-agent4412026年10月12日 更新

Write, compose, integrate, and improve programs that call Jev, TypeSafe's System One judgment model.

日本語の概要は準備中です。原文の説明を表示しています。

notque/vexjoy-agent4412026年10月12日 更新

notque のスキルをすべて見る

このスキルの問題を報告する