本文へ移動
cccskills
無料GitHub で公開

review

Review code changes against project architecture, style, and conventions

インストール方法を見る

含まれるファイル(1)

  • SKILL.md2.3 KB

SKILL.md(原文)

インストールする前に、エージェントに与えられる指示の中身を確認できます。

Review Changes

Review the current changes against the project's conventions and architecture rules.

Load the appropriate docs based on which code area is being reviewed:

  • Store code: @docs/store-compose.md, @docs/store-viewmodel-patterns.md, @docs/store-tracking-events.md, @docs/store-testing.md
  • POS code: @docs/pos-architecture.md, @docs/pos-tracking-events.md, @docs/pos-testing.md
  • Shared: @docs/coding-style.md

Steps

  1. Determine the diff to review. First check git diff trunk...HEAD for branch changes (most common: pre-PR review). If empty, fall back to git diff --cached for staged changes, then git diff for unstaged changes.

  2. Determine if the code is POS or store. POS: ui/woopos/, WooPos* prefix. Everything else: store management. Read the relevant docs above.

  3. Read the changed files in full to understand context, not just the diff hunks.

  4. Check against each category below. Only report actual issues found — do not report categories with no issues.

Architecture

  • POS: ViewModels extend ViewModel(), use parent-child SharedFlow event bus, pure Compose, Compose Navigation
  • Store: ViewModels extend ScopedViewModel, use triggerEvent() / MultiLiveEvent, Compose inside Fragments, XML nav graphs
  • Both: @HiltViewModel + @Inject constructor, data flows through repositories, ViewModels never access Room/network directly

Kotlin Style

  • Max 120 character line length (test names excepted)
  • No wildcard imports, no FIXME (use TODO), no !! force unwraps
  • Constants: UPPER_SNAKE_CASE, companion objects at bottom

Jetpack Compose

  • Check against patterns in docs/store-compose.md (store) or docs/pos-architecture.md (POS)

Testing

  • Store: BaseUnitTest, testBlocking, captureValues, AssertJ
  • POS: WooPosCoroutineTestRule, runTest, advanceUntilIdle, AssertJ

Analytics

  • Store: AnalyticsEvent enum, AnalyticsTrackerWrapper
  • POS: WooPosAnalyticsEvent sealed class, WooPosAnalyticsTracker

Output Format

## Blockers
- [file:line] Description of blocking issue

## Suggestions
- [file:line] Description of improvement suggestion

## Positives
- Description of what was done well

レビュー

まだレビューはありません。使ってみた感想をお寄せください。

同じリポジトリのスキル

概要と使いどころ

Repair a failing WooCommerce Android Maestro flow by reproducing it against the store it runs on, inspecting Maestro selectors, patching the smallest selector/wait/setup issue, and rerunning with repeat evidence. Human-triggered only.

日本語の概要は準備中です。原文の説明を表示しています。

woocommerce/woocommerce-android3192026年10月10日 更新

pos

無料

POS (Point of Sale) architecture and patterns. Use when writing, editing, exploring, debugging, fixing bugs, implementing features, or reviewing WooPos-prefixed classes or files under ui/woopos/. POS uses a different architecture than the main app — plain ViewModel (not ScopedViewModel), pure Compose (no Fragments), Compose Navigation (no nav graphs), parent-child SharedFlow event bus. Loading this skill prevents applying main-app patterns that would be wrong for POS. For analytics use `pos-analytics`, for tests use `pos-tests`.

日本語の概要は準備中です。原文の説明を表示しています。

woocommerce/woocommerce-android3192026年10月10日 更新

POS analytics tracking patterns (WooPosAnalyticsEvent sealed class, WooPosAnalyticsTracker, WooPosAnalyticsEventConstant). Use when writing, editing, exploring, debugging, or reviewing analytics tracking in POS (WooPos*) code. NOT for main store app — use the `store-analytics` skill instead.

日本語の概要は準備中です。原文の説明を表示しています。

woocommerce/woocommerce-android3192026年10月10日 更新

pos-tests

無料

POS unit testing patterns (WooPosCoroutineTestRule, runTest, advanceUntilIdle, mockito-kotlin, event bus mocking, analytics verification). Use when writing, editing, exploring, debugging, or reviewing unit tests for POS (WooPos*) code. NOT for main store app tests — use the `store-tests` skill instead.

日本語の概要は準備中です。原文の説明を表示しています。

woocommerce/woocommerce-android3192026年10月10日 更新

pr

無料

Create a pull request following project conventions. Triggers on any request to create, open, make, submit, file, send, push, spin up, put up, draft, raise, or prepare a PR/pull request.

日本語の概要は準備中です。原文の説明を表示しています。

woocommerce/woocommerce-android3192026年10月10日 更新

Address PR reviewer feedback by evaluating comments, proposing fixes, and executing after user approval. Use when the user wants to handle review comments on an existing PR, address PR feedback, fix PR comments, respond to reviewer suggestions, or process code review feedback. Triggers on "address PR feedback", "handle review comments", "fix PR comments", "respond to PR review", "process reviewer feedback", or when given a PR number/URL with intent to address its comments.

日本語の概要は準備中です。原文の説明を表示しています。

woocommerce/woocommerce-android3192026年10月10日 更新

woocommerce のスキルをすべて見る

このスキルの問題を報告する